feat(i18n): replace hardcoded upload strings in FeedCreateModal with i18n keys#303
Open
marsii1017 wants to merge 1 commit intoopenagents-org:developfrom
Open
feat(i18n): replace hardcoded upload strings in FeedCreateModal with i18n keys#303marsii1017 wants to merge 1 commit intoopenagents-org:developfrom
marsii1017 wants to merge 1 commit intoopenagents-org:developfrom
Conversation
…i18n keys Three strings in the file attachment label were hardcoded in English: - "Uploading..." (shown while upload is in progress) - "Select file" (shown when a connector is available) - "Connect to upload" (shown when no connector is available) `createModal.selectFile` already existed in all four locales but was not being used. Added the two missing keys (`uploading`, `connectToUpload`) to en, zh-CN, ja, and ko locale files, then replaced all three hardcoded strings with `t()` calls. Made-with: Cursor
|
@marsii1017 is attempting to deploy a commit to the Raphael's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Hi @nebukaga and @pjymint, sorry to bother you both.(Tag you both since you have most highest commits in the repro) I’ve been waiting on this PR for a few days, and at the moment I’m also blocked by Vercel since the deployment requires approval from a member of Raphael's projects team. When you have a chance, would you mind taking a look? I’d really appreciate it. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FeedCreateModal.tsxhad three English-only hardcoded strings in the file attachment section:"Uploading...","Select file", and"Connect to upload"createModal.selectFilealready existed in all four locale files (en, zh-CN, ja, ko) but was not being used — this PR finally wires it up and is accessible for the international usersuploading,connectToUpload) to all four locale files with proper translationst()and will automatically adapt to the user's languageFeedCreateModal.tsxt()callslocales/en/feed.jsonuploading,connectToUploadlocales/zh-CN/feed.jsonuploading,connectToUploadlocales/ja/feed.jsonuploading,connectToUploadlocales/ko/feed.jsonuploading,connectToUpload