This repository was archived by the owner on Apr 8, 2022. It is now read-only.
Update electron #61
Open
Update electron #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds and seems to work just fine, but I want to do some testing first.
…build as electron because is a native module
Collaborator
|
If we can get the oauth scope issue fixed i'd like to get this tested and added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change "openwmail-spellchecker" module to "nodehun" because "openwmail-spellchecker" is specialy builded for electron 1.6.*
Added un command to build "nodehun" for electron 1.8.8 because it's a native module: npm run-script rebuild:electron
I can't test on MAC OS but that's work great on ubuntu 18.04 ;)