Fix LED channel case inconsistency in ESP32LEDMatrixManager #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ESP32LEDMatrixManagerwas settingchannel_index = "led"(lowercase), causing it to fail case-sensitive comparisons for"LED"inESP32LEDLaserManager.pyand breaking LED channel recognition.Changes
channel_indexfrom"led"to"LED"inESP32LEDMatrixManager.__init__()to match:ESP32LEDLaserManager.setEnabled()(line 96) andsetValue()(line 114)"LED"values in configuration files (example_histo_daheng.json, FRAME2b.json, example_uc2.json)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.