Implement snbk snapshot metadata update#1104
Open
jamesljlster wants to merge 2 commits intoopenSUSE:masterfrom
Open
Implement snbk snapshot metadata update#1104jamesljlster wants to merge 2 commits intoopenSUSE:masterfrom
jamesljlster wants to merge 2 commits intoopenSUSE:masterfrom
Conversation
Contributor
Author
|
The latest commit (1844cd1), rearranges the precondition checks for snapshot restoration. The change avoids an inappropriate error message when trying to restore a legacy snapshot, which is already on the source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements snapshot metadata update for
snbk.A for-loop shell command is used to calculate checksums instead of using a wildcard path. This avoids the following issues:
Snapshot metadata updating is combined in the transfer function. No new snapshot operation function is introduced.
Detail changes:
CmdMetaHashmodule to compute metadata hashes (usingsha256sum).TheBigThing::TargetState::LEGACY, indicating that the source snapshot's metadata has changed since the transfer. Snapshots in the target stateLEGACYare also valid as Btrfs send parents.target-sha256sum-binto backup config for customization.resolve #1103