Add archiving option, fix exceptions, caused by multiline content in rpm spec files, remove shebangs, fix missing provides_extra field

[huakim]

No description provided.

[danigm]

Looks mostly good. I think that the optional libarchive dep can be avoided using the python standard library.

Also the sanitize of multiline fields can be done in the fix_data function instead of in templates.

[danigm]

Why do you need libarchive new dep here? Maybe it's possible to use standard python module tarfile or zipfile?

[huakim]

we can add if libarchive is None: pypi_archive_file_using_tarfile_or_zipfile(file_path) later here

[danigm]

I think it's not needed to modify the templates, you have defined the new fix_data function, what if we do this sanitize operation there instead of doing it in the templates? We can add to the fix_data function something like:

    single_line_fields = ['summary', 'license', 'home_page', 'source_url']
    for field in single_line_fields:
        if field not in data_info:
            continue
        # remove line breaks to avoid multiline rpm spec file
        data_info[field] = data_info[field].replace('\n', ' ')

[danigm]

Why are you removing these example files?