fix: QString from QByteArray changes with Qt6 #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in Qt6, the behavior of the QString(QByteArray) constructor was changed, see https://doc.qt.io/qt-6/qstring.html#QString-4 - this causes a NULL byte at the end of a QByteArray to be included in the resulting QString - this again causes problems when the result is used to construct further DBus calls - remove NULL bytes from QByteArray to fix this
Contributor
Author
|
Any comments to this fix? Without it imagewriter does not work with Qt 6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was detected by Edgar Aichinger while building the package on OBS for TW.