Skip to content

Conversation

@taroth21
Copy link
Contributor

PR creator: Description

Use * instead of <trademark> tag for 3rd party products to comply with legal recommendations.

PR creator: In case of entity changes

If you request an entity change: Please check all doc repositories for
occurrences of this entity (including all supported maintenance branches).
If there are any side-effects that come with the entity change you need to fix
those (after this PR has been accepted and rolled out via doc-kit).

  • all related fixes in the affected doc repositories and branches are done

PR reviewer: Due diligence

  • I have tested the changes in a test repository

In case of entity changes (product names etc.):

  • I have checked the changes against our terminology database and found no conflicts

- use * instead of <trademark> tag for 3rd party products,
  comply with legal recommendation
Copy link
Contributor

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afaerber
Copy link
Member

afaerber commented Jan 24, 2025

LGTM from doc-modular/main perspective (where they seemed unused anyway).

Regarding the above checklist, have you checked whether they're used elsewhere and, if so, whether the footer explains that star?

@taroth21
Copy link
Contributor Author

LGTM from doc-modular/main perspective (where they seemed unused anyway).

Regarding the above checklist, have you checked whether they're used elsewhere and, if so, whether the footer explains that star?

Not yet, I will do so on Monday before I merge this one (would like to do the check with a fresh mind).

@tbazant
Copy link
Contributor

tbazant commented Jan 14, 2026

@taroth21 can you make the same changes to general-attributes.adoc pls?

Copy link
Contributor

@tbazant tbazant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update generic-attributes.adoc as well pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants