WIP: Handle concrete process and whole process group when stopping#64
Draft
Martchus wants to merge 1 commit intoopenSUSE:masterfrom
Draft
WIP: Handle concrete process and whole process group when stopping#64Martchus wants to merge 1 commit intoopenSUSE:masterfrom
Martchus wants to merge 1 commit intoopenSUSE:masterfrom
Conversation
In case the process group could not be created it makes sense to at least take care of the concrete process. Otherwise, when `stop` is invoked before `setpgrp(0, 0)` (or `setpgrp(0, 0)` is for some reason not invoked after all) `stop` would not be able to do anything. This fix is similar to c4c7930 but for the `stop` function. However, in this case the limitation has existed for a long time and not just since ba7bb38. As far as I can tell it hasn't mattered much in production so far, though. Related ticket: https://progress.opensuse.org/issues/170209
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case the process group could not be created it makes sense to at least take care of the concrete process. Otherwise, when
stopis invoked beforesetpgrp(0, 0)(orsetpgrp(0, 0)is for some reason not invoked after all)stopwould not be able to do anything.This fix is similar to c4c7930 but for the
stopfunction. However, in this case the limitation has existed for a long time and not just since ba7bb38. As far as I can tell it hasn't mattered much in production so far, though.Related ticket: https://progress.opensuse.org/issues/170209