Skip to content

Conversation

@lzehl
Copy link
Member

@lzehl lzehl commented Nov 14, 2025

solves: #400

depends on: openMetadataInitiative/openMINDS_controlledTerms#514
(this is most likely why validation fails; so 514 in controlled terms should be merged first)

@lzehl lzehl requested a review from apdavison November 14, 2025 14:43
@lzehl lzehl self-assigned this Nov 14, 2025
@lzehl lzehl added request any request or update for instances that are not covered by Technique, ContentType or SANDS label major update large workload or major update needed to complete v5.0 candidate labels Nov 14, 2025
@lzehl lzehl changed the title Update definition and preferredOntologyIdentifier dependency impact library Nov 14, 2025
@lzehl lzehl marked this pull request as ready for review November 14, 2025 14:59
Copy link
Member

@apdavison apdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid the terms "dependent" (or "dependant") and "dependee", since the produce a lot of confusion - the meaning of dependant outside of software engineering is the opposite of the way it is usually used in a software context - https://english.stackexchange.com/questions/25575/what-is-the-correct-word-for-dependee

I suggest rewording along these lines:

Essential or mission-critical features of a dependent stop working if the dependee is unavailable.
Essential or mission-critical features of a system stop working if the thing it depends on is unavailable.

For the same reason, it would be better to use "dependsOn" for the property, rather than "dependency"

@lzehl
Copy link
Member Author

lzehl commented Nov 17, 2025

Definitions are updated @apdavison :)

@lzehl lzehl requested a review from apdavison November 17, 2025 15:53
Copy link
Member

@apdavison apdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intended "[system|thing]" as a placeholder. I think we need to pick one of those words.

@lzehl lzehl requested a review from apdavison November 17, 2025 16:26
Copy link
Member

@apdavison apdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Should I merge this? Did you already discuss these terms with Oli?

@lzehl
Copy link
Member Author

lzehl commented Dec 15, 2025

@olinux @annapaola can you please have a look at this PR as well and give feedback if this matches your expectations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major update large workload or major update needed to complete request any request or update for instances that are not covered by Technique, ContentType or SANDS label v5.0 candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants