-
Notifications
You must be signed in to change notification settings - Fork 16
dependency impact library #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
apdavison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid the terms "dependent" (or "dependant") and "dependee", since the produce a lot of confusion - the meaning of dependant outside of software engineering is the opposite of the way it is usually used in a software context - https://english.stackexchange.com/questions/25575/what-is-the-correct-word-for-dependee
I suggest rewording along these lines:
Essential or mission-critical features of a dependent stop working if the dependee is unavailable.
Essential or mission-critical features of a system stop working if the thing it depends on is unavailable.
For the same reason, it would be better to use "dependsOn" for the property, rather than "dependency"
Updated definition to clarify dependency context.
Updated the definition to clarify the dependency impact on data retrieval.
|
Definitions are updated @apdavison :) |
apdavison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intended "[system|thing]" as a placeholder. I think we need to pick one of those words.
apdavison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
Should I merge this? Did you already discuss these terms with Oli?
|
@olinux @annapaola can you please have a look at this PR as well and give feedback if this matches your expectations? |
solves: #400
depends on: openMetadataInitiative/openMINDS_controlledTerms#514
(this is most likely why validation fails; so 514 in controlled terms should be merged first)