Skip to content

Conversation

@UlrikeS91
Copy link
Contributor

Discussed during an offline meeting with @lzehl

Planned updates:

  • Add BrainAtlasVersion representing the parcellation scheme from 2006 (1st version of the atlas)
  • Add respective ParcellationEntityVersions for the atlas version (i.e., segmented regions when scheme is applied to MRI scans)
  • Update BrainAtlas with some more metadata
  • Minor changes to the existing PEs since I found some mistakes when comparing the information from the original publication
  • Updates to PEs with some more metadata

@UlrikeS91 UlrikeS91 self-assigned this Jun 25, 2025
@UlrikeS91 UlrikeS91 added the SANDS SANDS related instances - addition of new or update of existing ones label Jun 25, 2025
@UlrikeS91
Copy link
Contributor Author

UlrikeS91 commented Sep 9, 2025

One thing besides the comments for license and names in BAV:

I left the license still blank. We can still contact them at some point but until then, we shouldn't assume anything.

Names of BA(V) is change to your suggestion.

  • "temporal lobe - lateral aspect" (PE)
  • "temporal lobe - medial aspect" (PE)

You avoided everywhere else the "-" in the preferred name but moved this to the alternate names. Could we do the same for these two?

If not: I don't like that the "-" was replaced with an "" in the lookup label and atids (we use "" as separator now for these properties and should avoid introducing them for elements that belong together)

All else looks good :)

The logic was to follow what they have reported in their publication. This was their only exception and the others alternate names with dashes were included in figures or similar. Anyway, I don't mind changing it and it's not making the representation wrong, so I change it to "lateral/medial temporal lobe" with "temporal lobe - lateral/medial aspect" as alternate name (and change all references of this where it is used as parent and in the PT).

@UlrikeS91 UlrikeS91 requested a review from lzehl September 9, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SANDS SANDS related instances - addition of new or update of existing ones

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants