-
Notifications
You must be signed in to change notification settings - Fork 16
Add a content-type for the source code for NEST extension modules #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… produced by NESTML, for example)
instances/latest/contentTypes/application_vnd.nest-simulator.model+cpp.jsonld
Outdated
Show resolved
Hide resolved
instances/latest/contentTypes/application_vnd.nest-simulator.model+cpp.jsonld
Outdated
Show resolved
Hide resolved
instances/latest/contentTypes/application_vnd.nest-simulator.model+cpp.jsonld
Show resolved
Hide resolved
|
Note : if the auto population is not merged yet by time of merging this PR we need to provide this CT also for the other versions |
instances/latest/contentTypes/application_vnd.nest-simulator.model+cpp.jsonld
Show resolved
Hide resolved
| ], | ||
| "name": "application/vnd.nest-simulator.model+cpp", | ||
| "relatedMediaType": "text/x-c", | ||
| "relatedMediaType": "https://mimetype.io/text/x-c", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mh... this seems not be an official media type registered in iana.org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably then not provide this relation at all. Could you double check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find an entry at iana.org - the initial "x-" generally indicates a non-standard (but widely used) media type.
Since the number of media types registered in iana.org is so small, I would like to propose relaxing our requirements for this property. mimetype.io seems like quite a comprehensive resource; I think we should also allow putting other openMINDS content types here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might be point for v5.0. could you raise this in an issue please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "name": "application/vnd.nest-simulator.model+cpp", | ||
| "relatedMediaType": "https://mimetype.io/text/x-c", | ||
| "specification": "https://nest-extension-module.readthedocs.io/en/latest/extension_modules.html", | ||
| "synonym": null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a more human readable name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of anything that isn't just rephrasing the description, i.e. "Source code for an extension module for the NEST simulator"
(as produced by NESTML, for example)