-
Notifications
You must be signed in to change notification settings - Fork 16
add content-type: siibra meta.json #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add content-type: siibra meta.json #271
Conversation
| "description": null, | ||
| "displayLabel": null, | ||
| "fileExtension": [ | ||
| "meta.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should start with a point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even if (by specification) the file should always have the same stem so to speak?
(i.e. the file has to have the filename meta.json)
instances/latest/contentTypes/application_vnd.siibra.meta+json.jsonld
Outdated
Show resolved
Hide resolved
| "@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.siibra.meta+json.jsonld", | ||
| "@type": "https://openminds.om-i.org/types/ContentType", | ||
| "dataType": null, | ||
| "description": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a short description of the purpose of this content type. And a (short) display label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check updated version.
| "fileExtension": [ | ||
| "meta.json" | ||
| ], | ||
| "name": "application/vnd.siibra.meta+json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this siibra version independent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a good point.
we have prepared the schema such that, main schema is version independent (json schema wise, the versionless schema provides oneOf to one of the versions)
I understand for voluba, we did register a versioned schema.
If it is preferred register the version(s) separately, I would be happy to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the schema works for all versions you don't need to, if it does not, you need to register the ones that are needed for the versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the moment, the schema works for all version(s) (at the moment, there exist only one).
all changes to v1 will be proressive (i.e. would not be breaking, and only adds, never subtracts)
should there be a breaking change in the future, v2 will be introduced, but still covered by the same schema. versions are clearly demarkaged by version required property.
it is up to the client to decide to which extent (or indeed, if) it chooses to be able to load the file based on the version required property.
instances/latest/contentTypes/application_vnd.siibra.meta+json.jsonld
Outdated
Show resolved
Hide resolved
|
Note: we do not have the auto population running yet. In case this is not yet enabled by the merge of this PR we should provide this CT also for the other versions |
added: datatype/label/desc
| "@id": "https://openminds.om-i.org/instances/dataType/associativeArray" | ||
| } | ||
| ], | ||
| "description": "Sidecar file to volumetric/raster filebundle, providing metadata to the said bundle", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "description": "Sidecar file to volumetric/raster filebundle, providing metadata to the said bundle", | |
| "description": "Sidecar file to volumetric/raster a file bundle, providing metadata to the said bundle.", |
| "@context": { | ||
| "@vocab": "https://openminds.om-i.org/props/" | ||
| }, | ||
| "@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.siibra.meta+json.jsonld", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.siibra.meta+json.jsonld", | |
| "@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.siibra.meta+json", |
| "description": "Sidecar file to volumetric/raster filebundle, providing metadata to the said bundle", | ||
| "displayLabel": "siibra meta.json file", | ||
| "fileExtension": [ | ||
| "meta.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "meta.json" | |
| ".meta.json" |
???
| ], | ||
| "name": "application/vnd.siibra.meta+json", | ||
| "relatedMediaType": null, | ||
| "specification": "https://raw.githubusercontent.com/FZJ-INM1-BDA/siibra-explorer/refs/heads/master/.metaSpec/meta.schema.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is pointing to the following which does not give a lot of insight:
{
"$schema": "http://json-schema.org/draft-07/schema",
"oneOf": [{
"$ref": "meta.schema.v1.json"
}]
}
Where is the ref pointing to?
fixes #269
in draft. waiting for imminent release[1] of siibra-explorer, and update of specification URI.
[1] FZJ-INM1-BDA/siibra-explorer#1483