Skip to content

Conversation

@xgui3783
Copy link

fixes #269

in draft. waiting for imminent release[1] of siibra-explorer, and update of specification URI.

[1] FZJ-INM1-BDA/siibra-explorer#1483

"description": null,
"displayLabel": null,
"fileExtension": [
"meta.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should start with a point

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if (by specification) the file should always have the same stem so to speak?

(i.e. the file has to have the filename meta.json)

"@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.siibra.meta+json.jsonld",
"@type": "https://openminds.om-i.org/types/ContentType",
"dataType": null,
"description": null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a short description of the purpose of this content type. And a (short) display label

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check updated version.

"fileExtension": [
"meta.json"
],
"name": "application/vnd.siibra.meta+json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this siibra version independent?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good point.

we have prepared the schema such that, main schema is version independent (json schema wise, the versionless schema provides oneOf to one of the versions)

I understand for voluba, we did register a versioned schema.

If it is preferred register the version(s) separately, I would be happy to do so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the schema works for all versions you don't need to, if it does not, you need to register the ones that are needed for the versions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the moment, the schema works for all version(s) (at the moment, there exist only one).

all changes to v1 will be proressive (i.e. would not be breaking, and only adds, never subtracts)

should there be a breaking change in the future, v2 will be introduced, but still covered by the same schema. versions are clearly demarkaged by version required property.

it is up to the client to decide to which extent (or indeed, if) it chooses to be able to load the file based on the version required property.

@lzehl
Copy link
Member

lzehl commented Mar 14, 2025

Note: we do not have the auto population running yet. In case this is not yet enabled by the merge of this PR we should provide this CT also for the other versions

@apdavison apdavison added the ContentType ContentType instances - addition of new or update of existing ones label Mar 14, 2025
added: datatype/label/desc
"@id": "https://openminds.om-i.org/instances/dataType/associativeArray"
}
],
"description": "Sidecar file to volumetric/raster filebundle, providing metadata to the said bundle",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Sidecar file to volumetric/raster filebundle, providing metadata to the said bundle",
"description": "Sidecar file to volumetric/raster a file bundle, providing metadata to the said bundle.",

"@context": {
"@vocab": "https://openminds.om-i.org/props/"
},
"@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.siibra.meta+json.jsonld",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.siibra.meta+json.jsonld",
"@id": "https://openminds.om-i.org/instances/contentTypes/application_vnd.siibra.meta+json",

"description": "Sidecar file to volumetric/raster filebundle, providing metadata to the said bundle",
"displayLabel": "siibra meta.json file",
"fileExtension": [
"meta.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"meta.json"
".meta.json"

???

],
"name": "application/vnd.siibra.meta+json",
"relatedMediaType": null,
"specification": "https://raw.githubusercontent.com/FZJ-INM1-BDA/siibra-explorer/refs/heads/master/.metaSpec/meta.schema.json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is pointing to the following which does not give a lot of insight:

{
    "$schema": "http://json-schema.org/draft-07/schema",
    "oneOf": [{
        "$ref": "meta.schema.v1.json"
    }]
}

Where is the ref pointing to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ContentType ContentType instances - addition of new or update of existing ones

Projects

None yet

Development

Successfully merging this pull request may close these issues.

siibra-toolsuite meta.json content type

3 participants