-
Notifications
You must be signed in to change notification settings - Fork 11
Schema updates of research product(s) (versions) for v5.0 release #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v5
Are you sure you want to change the base?
Conversation
|
These changes are not backward compatible, it would be better to merge them into a new branch, v5. |
Removed the 'author' field from the brain atlas schema.
Removed author and license fields from brain atlas version schema.
Removed author and license fields from the schema.
lzehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- removed author from BA, BAV, CS, CSV (is now replaced by RP(V) inherited contributor property from core)
- removed license from BAV, CSV (is now replaced by RPV inherited usageCondition property from core)
- solved conflict (with already merged updates for RP-RPV directionality)
@Raphael-Gazzotti could you double check and merge if okay?
…work.schema.tpl.json
…teFrameworkVersion.schema.tpl.json
…dinateFramework.schema.tpl.json
|
@lzehl, I made the changes described in the related issue. While implementing them, I noticed that this would also affect the category "coordinateSpace" and some other schemas. So, I updated the "customCoordinateSpace" as well (which is anyway the most coherent way of dealing with this) and all other "space"-uses across different SANDS schemas (i.e., coordinatePoint and customAnnotation). The category was only used once, in core:FileBundle/groupedBy which is updated in openMetadataInitiative/openMINDS_core#569. |
…sVersion.schema.tpl.json
|
Instances in" latest" will need to be updated, should we also consider to rename the folders (brainAtlasVersions, brainAtlases, commonCoordinateSpaceVersions, commonCoordinateSpaces)? |
#300