Adoption python pipeline to new namespace #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peyman-N
commented
Dec 20, 2024
| # This is probably not the most elegant or fast way to do this, but it is simple and robust. | ||
| for node in tuple(self.nodes.values()): | ||
|
|
||
| if node.type_.startswith("https://openminds.ebrains.eu/"): |
Member
Author
There was a problem hiding this comment.
This is not the best way to detect the version. Perhaps we should add a property to the collection JSON file when saving, indicating which version of openMINDS it was produced with.
apdavison
requested changes
Dec 20, 2024
Member
apdavison
left a comment
apdavison
left a comment
There was a problem hiding this comment.
I haven't tried the code, but it looks generally good. A few suggestions inline.
pipeline/translator.py
Outdated
| linked.update(property.get("_linkedTypes", [])) | ||
| return embedded, linked | ||
|
|
||
| def get_module_dict(self,class_module_dict): |
Member
There was a problem hiding this comment.
I suggest renaming this update_class_to_module_map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.