Skip to content

Conversation

@ehennestad
Copy link
Collaborator

Refactor and update openminds.abstract.Schema

  • Fixed isReference() to support non-scalar objects
  • Added getUnresolvedLinks for retrieving identifiers for all linked nodes of a metadata instance
  • Added isUnresolved public method

Introduces the getUnresolvedLinks method to retrieve identifiers of unresolved linked instances. Also adds input argument validation to getLinkedInstances and getEmbeddedInstances for improved robustness.
Relocated the assignInstanceId method within the Schema class
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Test Results (R2021b)

548 tests  ±0   548 ✅ ±0   1m 33s ⏱️ -15s
 16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 47eb29a. ± Comparison against base commit 9f4fb4a.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Test Results (R2024b)

548 tests  ±0   548 ✅ ±0   1m 25s ⏱️ -4s
 16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 47eb29a. ± Comparison against base commit 9f4fb4a.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.51%. Comparing base (9f4fb4a) to head (47eb29a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
code/internal/+openminds/+abstract/Schema.m 31.25% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   75.73%   75.51%   -0.22%     
==========================================
  Files         339      339              
  Lines        3655     3668      +13     
==========================================
+ Hits         2768     2770       +2     
- Misses        887      898      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehennestad ehennestad merged commit 4ece2fb into main Oct 7, 2025
8 checks passed
@ehennestad ehennestad deleted the x/add-get-unresolved-links-method branch October 7, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants