Skip to content

Conversation

@ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Mar 30, 2025

  • Incorporates changes from openMINDS main repository
  • Add HasControlledInstances as mixin to types which have controlled instances

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2025

Test Results

465 tests  +1   465 ✅ +1   59s ⏱️ +3s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 594c9e7. ± Comparison against base commit c963f18.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
testReadTheDocLinks ‑ testSchemaDocLink(modelVersion=v1.0)
InstanceTest ‑ testCreateSchema(SchemaType=MRAcquisitionType)
InstanceTest ‑ testSaveLoadForSchema(SchemaType=MRAcquisitionType)

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 3.03030% with 32 lines in your changes missing coverage. Please review.

Project coverage is 36.04%. Comparing base (c963f18) to head (102c194).

Files with missing lines Patch % Lines
...chemas/latest/+openminds/+core/+data/ContentType.m 0.00% 4 Missing ⚠️
...de/schemas/latest/+openminds/+core/+data/License.m 0.00% 4 Missing ⚠️
...hemas/latest/+openminds/+sands/+atlas/BrainAtlas.m 0.00% 4 Missing ⚠️
...atest/+openminds/+sands/+atlas/BrainAtlasVersion.m 0.00% 4 Missing ⚠️
...t/+openminds/+sands/+atlas/CommonCoordinateSpace.m 0.00% 4 Missing ⚠️
...minds/+sands/+atlas/CommonCoordinateSpaceVersion.m 0.00% 4 Missing ⚠️
...test/+openminds/+sands/+atlas/ParcellationEntity.m 0.00% 4 Missing ⚠️
...penminds/+sands/+atlas/ParcellationEntityVersion.m 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   36.39%   36.04%   -0.35%     
==========================================
  Files         326      327       +1     
  Lines        3171     3204      +33     
==========================================
+ Hits         1154     1155       +1     
- Misses       2017     2049      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehennestad ehennestad merged commit d13ea5a into main Apr 3, 2025
@ehennestad ehennestad deleted the staging branch April 3, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants