fix: handle template imports without file extensions #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The emitter incorrectly used filepath.Ext() to distinguish template
imports from native package imports. This caused imports without file
extensions to be silently skipped, resulting in:
panic: scriggo: internal error: none of the previous conditions
matched identifier <MacroName>
The correct check is node.Tree != nil, which indicates a template import
(parsed AST exists) vs node.Tree == nil for native package imports.
This matches the logic used in the type checker.
Changes:
- emitter_statements.go: Replace filepath.Ext check with node.Tree check
- fstest/files.go: Add FormatFiles type for testing extension-less imports
- multi_file_template_test.go: Add tests for extension-less macro/variable imports
gazerro
requested changes
Dec 14, 2025
Member
gazerro
left a comment
gazerro
left a comment
There was a problem hiding this comment.
Thanks for fixing this! I have a few comments below.
|
|
||
| // Tests for extension-less imports using FormatFiles (FormatFS interface) | ||
| "import with 'for' - macro without file extension": { | ||
| sources: fstest.FormatFiles{ |
Member
There was a problem hiding this comment.
It's not necessary to introduce fastest.FormatFiles, since files without an extension already default to the Text format. I'd recommend restoring internal/fstest/files.go to its previous state.
| expectedOut: "hello, world!", | ||
| }, | ||
|
|
||
| // Tests for extension-less imports using FormatFiles (FormatFS interface) |
Member
There was a problem hiding this comment.
I would remove this comment, as the test name already documents the behavior.
| pkg := node.Tree.Nodes[0].(*ast.Package) | ||
| funcs, vars, inits := em.emitPackage(pkg, false, node.Tree.Path) | ||
|
|
||
| // If importing specific identifiers with "for" clause, filter to only those. |
Member
There was a problem hiding this comment.
What is the purpose of this change? It's not documented in the commit message, and the issue seems to be fixed even without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emitter incorrectly used filepath.Ext() to distinguish template imports from native package imports. This caused imports without file extensions to be silently skipped, resulting in:
panic: scriggo: internal error: none of the previous conditions
matched identifier
The correct check is node.Tree != nil, which indicates a template import (parsed AST exists) vs node.Tree == nil for native package imports. This matches the logic used in the type checker.
Changes: