Skip to content

64 debug nan jersey num error sar#65

Merged
calvinyeungck merged 5 commits intomasterfrom
64-debug-nan-jersey-num-error-sar
Jan 30, 2026
Merged

64 debug nan jersey num error sar#65
calvinyeungck merged 5 commits intomasterfrom
64-debug-nan-jersey-num-error-sar

Conversation

@kenjiro-mk
Copy link
Collaborator

This pull request introduces several improvements and fixes to the soccer data preprocessing pipeline, focusing on more robust handling of missing data, improved error reporting, and enhanced code clarity through English comments and refactoring. The most significant changes include improved substitution event handling, replacing debugging breakpoints with assertion errors, and clarifying comments throughout the codebase.

Key changes:

Robust handling of substitutions and missing data:

  • Enhanced the get_changed_player_list function to fill missing jersey_number values for substitution events by inferring from player_name and home_away, improving data consistency across different leagues.
  • In get_timestamp, replaced a generic exception with a specific IndexError to improve error clarity when extracting frame IDs.

Error handling and debugging improvements:

  • Replaced pdb.set_trace() debugging breakpoints with explicit AssertionError exceptions in several functions (interpolate_ball_tracking_data, get_player_change_log_legacy, merge_ball_only_series) to ensure that unexpected data inconsistencies are surfaced as errors rather than halting execution for manual debugging. [1] [2] [3] [4]

Version update:

  • Bumped the package version from 0.1.42 to 0.1.43 in pyproject.toml to reflect these changes.

@github-actions
Copy link

Init Test Results 📝

  • Status: success
  • OS: Linux
  • Python: 3.10

@github-actions
Copy link

Init Test Results 📝

  • Status: success
  • OS: Linux
  • Python: 3.9

@github-actions
Copy link

Init Test Results 📝

  • Status: success
  • OS: Linux
  • Python: 3.8

@calvinyeungck calvinyeungck merged commit 413a935 into master Jan 30, 2026
3 checks passed
@calvinyeungck calvinyeungck deleted the 64-debug-nan-jersey-num-error-sar branch February 16, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants