Skip to content

Refactors holder ID mapping to improve clarity and efficiency #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calvinyeungck merged 1 commit into from
Nov 26, 2025
Merged

Refactors holder ID mapping to improve clarity and efficiency #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions preprocessing/sports/space_data/ultimate/ultimate_space_preprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,14 +216,13 @@ def create_events_metrica(df, tracking_herz):

# Get holder information
holder_data = df.loc[df["holder"]]
to_id = pd.Series([np.nan] * len(start_frame))
if not holder_data.empty:
to_id = (
holder_data["id"]
.map(lambda x: offense_ids.index(x) + 1 if x in offense_ids else np.nan)
.reset_index(drop=True)
)
else:
to_id = pd.Series([np.nan] * len(start_frame))
id_by_frame = holder_data.set_index("frame")["id"]
to_id.update(id_by_frame)
to_id = to_id.map(
lambda x: offense_ids.index(x) + 1 if x in offense_ids else np.nan
).reset_index(drop=True)

# Create the DataFrame for events
events_df = pd.concat(
Expand Down