Skip to content

Fix error and cleanup #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calvinyeungck merged 2 commits into from
Nov 25, 2025
Merged

Fix error and cleanup #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f65b1d1
Refactors imports and fixes preprocessing default
shunsuke-iwashita Nov 12, 2025
94bd09d
Removes debug print from tracking data load
shunsuke-iwashita Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions preprocessing/sports/space_data/basketball/basketball_space_class.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
import os
import zipfile

import gdown
import pandas as pd
from tqdm import tqdm
from scipy.io import loadmat
import pandas as pd
import gdown
import zipfile
import os
from tqdm import tqdm


class Basketball_space_data:
def __init__(self,data_provider,data_path, *args, **kwargs):
self.data_provider = data_provider
self.data_path = data_path


def preprocessing(self, nb_process_game):
def preprocessing(self, nb_process_game='ALL'):

if self.data_provider == "SportVU_NBA":

Expand Down Expand Up @@ -159,4 +159,5 @@ def download_data(self):

os.remove(output_zip_path)
print("delete the unecessary zip file")
return print("Data downloaded finish") print("delete the unecessary zip file")
return print("Data downloaded finish")
2 changes: 1 addition & 1 deletion preprocessing/sports/space_data/ultimate/ultimate_space_class.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def preprocessing(self):
os.path.splitext(os.path.basename(tracking_path_i))[0]
)[0]
match_tracking_df = pd.read_csv(tracking_path_i)
print(match_tracking_df)

# Create intermediate DataFrame with all required columns
intermidiate_df = create_intermediate_file(match_tracking_df)

Expand Down