benches/SPEC: Change small details #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always create the SPEC installation directory to avoid redundant existence checks and simplify the install path. Mark SPEC install and build commands as `output_is_log` so their output is treated as logging rather than benchmark data. Extract runtime reporting by taking the duration from the last run output instead of assuming a single entry. Update the run_once test to accept the SPEC ISO path as a CLI argument, making the test usable in real environments without hardcoded paths. Signed-off-by: Antonio Paolillo <apaolill@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always create the SPEC installation directory to avoid redundant existence checks and simplify the install path.
Mark SPEC install and build commands as
output_is_logso their output is treated as logging rather than benchmark data.Extract runtime reporting by taking the duration from the last run output instead of assuming a single entry.
Update the run_once test to accept the SPEC ISO path as a CLI argument, making the test usable in real environments without hardcoded paths.