compat: Fix propagation of other_variables #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new2old compatibility layer was incorrectly unpacking `other_variables`, causing values to be dropped or overridden when adapting the new execution context to the legacy API. Fix this by explicitly merging both `other_variables_inner` and `other_variables` into the legacy argument dictionary. Update the corresponding test to use the new `variables=` API instead of the deprecated `parameter_space=` keyword. Signed-off-by: Antonio Paolillo <apaolill@gmail.com>
matsvanmolle
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new2old compatibility layer was incorrectly unpacking
other_variables, causing values to be dropped or overridden when adapting the new execution context to the legacy API.Fix this by explicitly merging both
other_variables_innerandother_variablesinto the legacy argument dictionary.Update the corresponding test to use the new
variables=API instead of the deprecatedparameter_space=keyword.