benchmark.py: Decouple Tilt from legacy engine #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the Tilt shared-lib CMake configure/build helper into benchkit.sharedlibs.tiltlib and reuse it from the examples kit. Refactor TiltLib to build into a host-scoped build directory and enable locks by preloading lib<lock>.so from that build dir; drop legacy compiler/atomics/lock-path plumbing and raise a clear error if the requested lock lib is missing. examples/tilt: pin libvsync/tilt versions in setup README. Signed-off-by: Antonio Paolillo <apaolill@gmail.com>
Signed-off-by: Antonio Paolillo <apaolill@gmail.com>
apaolillo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all Tilt-specific logic from the base Benchmark class: drop
hardcoded TiltLib handling, tilt variable partitioning, pre-build
loops, and compiler logging. Record parameters are now split only into
build/run/other variables, with "other" variables propagated to
experiment validation.
Refactor sharedlibs/tilt to be self-contained: factor out a reusable
CMake configure/build helper, simplify TiltLib to build per-host
artifacts, and enable locks via lib.so LD_PRELOAD resolution with
clear failure modes.
Update examples to reuse the shared helper and pin libvsync/tilt
versions for reproducibility.