Updates to more recent dependencies #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
[skip ci]
Squashed commits: [4ddbf4e] Drop Windows tests for now [94f40ae] test failures may be due to new pytest version [e35e512] Missing CI dependency [6c73a1e] Tests failing on GH Actions, but passing locally - trying to debug [441540d] temporarily comment out flake8 on Actions, due to pyflakes failure for which I get no Google hits (and which doesn't occur locally) [9056357] Drop Python 3.7 support [e03a03f] Try the ubuntu-22.04 runner on GitHub Actions [4b01682] It seems there are no ubuntu-18.04 runners any more in GH actions. Let's see if the tests run on Mac OS, Windows. Reduce the number of Python versions tested to keep the total test matrix size reasonable.
[skip ci]
This is a partial solution to making projects portable: rather than hardcoding the entire path in .smt/projects, only the path relative to the home directory is hardcoded. This commit simply adds `os.path.expanduser` in the relevant places, allowing paths can be specified with '~' to indicate the home directory. It does not provide a mechanism to change how they are written to the project file; to make the project file portable, it needs to be edited by hand. If the project file is re-saved (e.g. with smt configure), the changes are overwritten. (cherry picked from commit 235abc0)
Importing `pkg_resources` causes errors on recent Python. The functionality we use is available as `import.resources.files` since Python 3.9; for Python 3.7 and 3.8, the backport `import_resources` is used; for Python ≤3.6, the old implementation with `pkg_resources` is used. (cherry picked from commit 7b9fb6d)
As far as I know, there is no advantage to using `f = open() ... f.close() when a `with open() as f:` will do. The `with` form deals better with corner cases where program execution ends unexpectedly, and is generally more Pythonic. (cherry picked from commit d5528a7)
(cherry picked from commit d73cede)
Adds the SerialTqdmLaunchMode, which disables stderr capture. This option to leave stderr as-is is propagated through a new keyword argument to `run()`. (cherry picked from commit 2a07202)
In cases where record parameters are malformed, they may not load correctly as a dict, and then `rec.parameters.pop` raises AttributeError. One may still want to compare the record to another however – for example, to identify differences with a record where parameters are not malformed. Adding a `hasattr` guard helps with this corner case, and as far as I can tell has no downsides. (cherry picked from commit 20abf3d)
(probably not detected earlier since I no longer had R installed, so these tests were being skipped)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it is a long time since Sumatra was updated, this is a large pull request. There is more to be done, given the rapid changes in the Python packaging ecosystem in recent years, such as moving to a pyproject.toml-based build/distribution system, but that will be done in a future PR.
Main changes:
The other changes are mostly related to the above.