OQSBuilder checkpoint: reproduce ML-KEM integrations#2348
Open
xuganyu96 wants to merge 18 commits intogyx-oqsbuilderfrom
Open
OQSBuilder checkpoint: reproduce ML-KEM integrations#2348xuganyu96 wants to merge 18 commits intogyx-oqsbuilderfrom
xuganyu96 wants to merge 18 commits intogyx-oqsbuilderfrom
Conversation
xuganyu96
force-pushed
the
gyx-oqsbuilder-structured-oqsbuildfile
branch
13 times, most recently
from
dafceb6 to
4747772
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| && apt-get install -y python3-venv \ | ||
| && python3 -m venv /.venv \ | ||
| && . /.venv/bin/activate \ | ||
| && pip install --upgrade pip wheel setuptools \ |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium
| && python3 -m venv /.venv \ | ||
| && . /.venv/bin/activate \ | ||
| && pip install --upgrade pip wheel setuptools \ | ||
| && pip install -r requirements.txt \ |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium
* Getting started with oqsbuilder. Can now clone some upstream remote repos Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca> * Fixed typos. Implemented dryrun for clone_remote_repo. Start tracking OQS Builder progress in oqsbuilder/README.md. [skip ci] Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca> --------- Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
* Can apply one patch to one repository Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca> * Resolved issue where git reports "... is beyond a sym link" on repository content within Python's TemporaryDirectory Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca> * Removed argparse because it is currently a distraction, will add later Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca> * Can apply patches to upstreams; enabled patches in the build YML file Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca> * When not running oqsbuilder headlessly, use user prompts [skip ci] Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca> --------- Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Proof-of-concept re-production of ML-KEM integration Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Started implementing structured OQSBuild class Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
…le generation Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
I had an idea for incrementally deploying OQSBuilder. In short, "copy from upstream" will now contain two steps: first run the legacy script `copy_from_upstream.py`, then run OQSBuilder. Hence the change in the "basic check" to run OQSBuilder in basic.yml's upstreamcheck. OQSBuilder has a separate set of Python dependencies specified in oqsbuilder/dev-requirements. Some of them (i.e. gersemi) are not available from Ubuntu's system package manager, so I chose to install python3-venv, then use pip inside a virtual environment. Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
xuganyu96
force-pushed
the
gyx-oqsbuilder-structured-oqsbuildfile
branch
from
19c4bb0 to
03845a1
Compare
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
dstebila
reviewed
Feb 18, 2026
| icicle_cuda: | ||
| enable_by: OQS_USE_ICICLE | ||
|
|
||
| copies: |
Member
There was a problem hiding this comment.
This is going to get quite large. Would it be useful to break copies out into its own file? Or possibly one YML file for each entry within copies, e.g., mldsa-native_x86_64, ...
dstebila
reviewed
Feb 18, 2026
| - 🔨 render documentation | ||
| - 🔨 !!! ML-DSA !!! | ||
| - ✅ Parse `oqsbuildfile.yml` into structured data instead of Python dictionary | ||
| - 🔨 Consider documenting oqsbuildfile's schema in Python code |
Member
There was a problem hiding this comment.
Yes, I think some documentation of oqsbuildfile.yml's schema will be necessary so that others will know how to use it. Would a Markdown file be better than in the Python code?
There are tools for codifying a scheme for a YAML file and also validating a YAML file against a schema, e.g., https://github.com/yaml-schema/yaml-schema. I don't know if that's overkill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request reproduces ML-KEM integration from mlkem-native, cupqc, and icicle.
OQSBuilder aims to improve upon
copy_from_upstream.pyby clarifying the data flow fromoqsbuildfile.yml(previouslycopy_from_upstream.yml) into Python data structures, then into actions such as cloning upstream repositories and rendering internal CMakeLists.txt/source/header files from Jinja templates.Reviewers might find it easier to start with
oqsbuilder/__main__.pyand read through the code.Feedback on design choices is very much appreciated.
NOTE: I have not gotten implementing fetching file list from remote
META.ymlfile, but this item is on the roadmap.