Skip to content

Hqc update reference implementation #2328

Open
vsoftco wants to merge 8 commits intomainfrom
hqc_update_vsoftco
Open

Hqc update reference implementation #2328
vsoftco wants to merge 8 commits intomainfrom
hqc_update_vsoftco

Conversation

@vsoftco
Copy link
Member

@vsoftco vsoftco commented Dec 1, 2025

Updates HQC to https://gitlab.com/pqc-hqc/hqc v5.0.0. Minimal changes in the upstream code.

Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com>
Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com>
Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com>
Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com>
Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com>
Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
@dstebila
Copy link
Member

dstebila commented Jan 6, 2026

Hi @vsoftco, I've tried to fix the code formatting CI failures by applying astyle following the instructions at https://github.com/open-quantum-safe/liboqs/blob/main/CONTRIBUTING.md#coding-style

Copy link
Contributor

@xuganyu96 xuganyu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vsoftco, this is unfortunately not adequate for updating liboqs's HQC implementation. These code changes will not build, and CI pipeline did not report failure only because HQC was disabled by default.

I understand that the lack of liboqs's documentation is making integrating additional implementation confusing. We are working on better docs and revamping upstream integration process. If you are still interested in contributing, feel free to raise an issue, and we can walk you through the process.

I will close this pull request for now.

cc: @dstebila

@xuganyu96 xuganyu96 closed this Jan 19, 2026
@dstebila dstebila reopened this Jan 22, 2026
@dstebila
Copy link
Member

I'd like to keep this open since it is a target feature of liboqs 0.16.0.

@dstebila dstebila added the focus Reserved for a small number of topics that have been identified as focus issues for the current week label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

focus Reserved for a small number of topics that have been identified as focus issues for the current week

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments