Skip to content

fix generate tls cert insecure algorithm SHA1-RSA#2

Open
redwarn wants to merge 4 commits intoopen-policy-agent:mainfrom
redwarn:main
Open

fix generate tls cert insecure algorithm SHA1-RSA#2
redwarn wants to merge 4 commits intoopen-policy-agent:mainfrom
redwarn:main

Conversation

@redwarn
Copy link
Copy Markdown

@redwarn redwarn commented Sep 6, 2022

What this PR does / why we need it:
fix generate tls cert script add -sha256 support
fix would violate PodSecurity "restricted:latest": unrestricted capabilities, add securityContext

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: yanhu.cheng <yanhu.cheng@binance.com>
…ities, add securityContext in values.yaml

Signed-off-by: yanhu.cheng <yanhu.cheng@binance.com>
{{- end }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove new line

- ALL
runAsNonRoot: true
seccompProfile:
type: RuntimeDefault No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add newline

enabled: true
caBundle: ""
skipVerify: false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove new line

Copy link
Copy Markdown
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redwarn thanks for the PR! couple nits in the comments

Signed-off-by: yanhu.cheng <yanhu.cheng@binance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants