deadcode: remove future date validator usage #9439
Conversation
Saby-Bishops
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| birthDate: [ | ||
| '', | ||
| this.conditionalValidator(CustomValidators.dateValidRequired).bind(this), | ||
| ac => this.validatorService.notDateInFuture$(ac) | ||
| this.conditionalValidator(CustomValidators.dateValidRequired).bind(this) | ||
| ], |
There was a problem hiding this comment.
The async notDateInFuture$ guard was removed, so birthDate now only checks that a value exists (CustomValidators.dateValidRequired) and the datepicker only enforces a minimum of 1900. Entering a future date (e.g., 2099-01-01) now passes validation and is saved to CouchDB, which can produce negative ages and inconsistent profile data. The same removal occurs in health-update.component.ts and users-achievements-update.component.ts, leaving all birthdate forms without any upper-bound validation.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task