Skip to content

community: smoother link dialog typed forms (fixes #9413) #9432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Saby-Bishops wants to merge 4 commits into
base: master
Choose a base branch
from
Open

community: smoother link dialog typed forms (fixes #9413) #9432

Saby-Bishops wants to merge 4 commits into from

Conversation

@Saby-Bishops
Copy link
Member

@Saby-Bishops Saby-Bishops commented Dec 11, 2025 •
edited by Mutugiii
Loading

fixes #9413

  • switch community link dialog form to typed controls with explicit model types
  • ensure stepper event handling and resets align with non-nullable typed form values
image

Codex Task

@Saby-Bishops Saby-Bishops marked this pull request as ready for review December 12, 2025 21:05
@Mutugiii
Copy link
Member

Mutugiii commented Dec 23, 2025

@codex review

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Dec 23, 2025

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Mutugiii Mutugiii changed the title src/app/community/community-link-dialog.component.ts (fixes #9413) community: link dialog typed forms (fixes #9413) Dec 30, 2025
@Mutugiii Mutugiii changed the title community: link dialog typed forms (fixes #9413) community: smoother link dialog typed forms (fixes #9413) Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mutugiii Mutugiii Mutugiii approved these changes

@jessewashburn jessewashburn jessewashburn approved these changes

@emmanuelbaa emmanuelbaa emmanuelbaa approved these changes

Assignees

No one assigned

Labels

codex ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

src/app/community/community-link-dialog.component.ts

5 participants

@Saby-Bishops @Mutugiii @jessewashburn @emmanuelbaa