resources: smoother icon downloading (fixes #9307) #9424
Conversation
Saby-Bishops
left a comment
Saby-Bishops
left a comment
There was a problem hiding this comment.
Please add a screenshot of the output, and include the relevant issue number in the PR description for easier tracking.
Done^ Please check |
JackTheSparow
changed the title
jessewashburn
left a comment
jessewashburn
left a comment
There was a problem hiding this comment.
It's nice that it refreshes after you remove an attachment, but you should not be able to do this, per the original issue (checked even when there is no attachment):
Also, If you include fixes #9307 in the body of the PR, it is much easier for the reviewers to directly link to the original issue.
JackTheSparow
force-pushed
the
9307-file-downloadable-is-selectable
branch
from
e67c215 to
47710f6
Compare
Mutugiii
left a comment
Mutugiii
left a comment
There was a problem hiding this comment.
Steps to replicate:
- Upload item
- Select
File downloadable - Delete the item
Mutugiii
left a comment
Mutugiii
left a comment
There was a problem hiding this comment.
Additional note, the showDownloadCheckbox and disableDownload variables are basically inverses most of the time. Sticking to one is ideal to reduce maintenance overhead
| this.file = null; | ||
| this.fileInput.clearFile(); | ||
| this.disableDownload = !this.existingResource.doc?._attachments || this.attachmentMarkedForDeletion; | ||
| this.disableDownload = true; |
There was a problem hiding this comment.
setting this to always true leads to a regression when editing a resource with a downloadable attachment.
Steps to test:
- Open an existing resource that already has an attachment (Edit mode).
- Attach a new file -> "Choose File"
- Remove the newly attached file
Result: The "File downloadable" checkbox disappears
dogi
changed the title
Fixes #9307
Fixed the checkbox enabled problem when file is deleted after selecting from local files. Checkbox automatically gets refreshed if file is deleted and not uploaded.
After Deleting File