Skip to content

Stabilize achievements form loading and unsaved-state handling #9398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Saby-Bishops wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Stabilize achievements form loading and unsaved-state handling #9398

Saby-Bishops wants to merge 2 commits into from

Conversation

@Saby-Bishops
Copy link
Member

@Saby-Bishops Saby-Bishops commented Dec 2, 2025

Summary

  • normalize legacy achievement documents by defaulting missing arrays, preserving revisions, and normalizing dialog input values
  • ensure unsaved-change tracking captures all form arrays and resets after confirmed navigation or successful saves
  • add component tests covering normalization, legacy document handling, and unsaved-change resets

Testing

  • npx ng test --watch=false --browsers=ChromeHeadless --include src/app/users/users-achievements/users-achievements-update.component.spec.ts --progress=false (fails: existing unrelated spec files reference removed APIs and missing components)

Codex Task

@Saby-Bishops Saby-Bishops marked this pull request as ready for review December 3, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessewashburn jessewashburn jessewashburn approved these changes

Assignees

No one assigned

Labels

codex triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Saby-Bishops @jessewashburn