fix: use URL encoding for password and username#4
Open
Conversation
fixes problems with passwords or usernames containing special URL characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the URL construction for the openware-config login by ensuring that special characters in the username and password are URL-encoded.
- Updates type assertions for username and password.
- Encodes username and password in the login URL to address encoding issues.
| if (host && port && username && password) { | ||
| const url = `${host}:${port}/api/users/login?username=${username}&password=${password}`; | ||
| const url = `${host}:${port}/api/users/login?username=${encodeURIComponent(username)}&password=${encodeURIComponent(password)}`; | ||
| console.log("Refreshing session", url); |
There was a problem hiding this comment.
Logging the complete URL including encoded credentials may expose sensitive information. Consider removing or redacting sensitive details from the log statement.
Suggested change
| console.log("Refreshing session", url); | |
| console.log("Refreshing session at", `${host}:${port}/api/users/login`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes problems with passwords or usernames containing special URL characters