chore(flagd): Add sync metadata disabled#211
Merged
gruebel merged 3 commits intoopen-feature:mainfrom Mar 12, 2025
Merged
Conversation
Signed-off-by: Maks Osowski <maks@google.com>
…mplexity pre-commit Signed-off-by: Maks Osowski <maks@google.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 93.96% 93.90% -0.07%
==========================================
Files 18 18
Lines 945 952 +7
==========================================
+ Hits 888 894 +6
- Misses 57 58 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
beeme1mr
approved these changes
Mar 12, 2025
toddbaert
approved these changes
Mar 12, 2025
gruebel
approved these changes
Mar 12, 2025
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/config.py
Outdated
Show resolved
Hide resolved
…rovider/flagd/config.py Co-authored-by: Anton Grübel <anton.gruebel@gmail.com> Signed-off-by: cupofcat <maks@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
sync.GetMetadataand add equivalent field tosync.SyncFlagspayload. flagd#1584Notes
GetMetadatacall was recently added in #195. This is potentially breaking for server implementations that don't support metadata. As such, this PR is a temporary stop-gap for such implementations, and it will be removed when metadata is deprecated with the completion of the above issue.There's no need to implement this in all languages, we'll do it at maintainer discretion according to user need.
This is similar to recently added option in the Java SDK: open-feature/java-sdk-contrib#1267
CC: @toddbaert @aepfli @gruebel