feat(flagd): Add features to customize auth to Sync API servers#203
feat(flagd): Add features to customize auth to Sync API servers#203gruebel merged 3 commits intoopen-feature:mainfrom
Conversation
Signed-off-by: Maks Osowski <maks@google.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 94.28% 93.96% -0.33%
==========================================
Files 18 18
Lines 928 945 +17
==========================================
+ Hits 875 888 +13
- Misses 53 57 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi, I am new in this repo :) Could you please advise about those failing checks? Thanks! |
|
Hey @cupofcat, it looks like you're running into a lint and type issue. It looks like you may be able to reproduce the lint issue locally by using |
gruebel
left a comment
There was a problem hiding this comment.
thanks 🍻 left a few minor comments
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/provider.py
Outdated
Show resolved
Hide resolved
...der-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py
Show resolved
Hide resolved
...der-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py
Show resolved
Hide resolved
...der-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py
Show resolved
Hide resolved
|
@cupofcat if you have issues with fixing the failing type check, let me know and I can fix it for you. |
Signed-off-by: Maks Osowski <maks@google.com>
|
Code looks good, let's wait a bit, if someone else has an opinion on it. if not, then I'll merge it next week. |
|
Hi there! Is there anything you would like me to change in this PR? Thanks! |
This PR
Notes
This is similar to recent changes for Go & Java: