Skip to content

feat: add @env-var tag to env-var config scenarios #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aepfli merged 2 commits into from
Mar 31, 2026
Merged

feat: add @env-var tag to env-var config scenarios #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2dc5eb
test: add @env-var tag to env-var config scenarios
aepfli Mar 30, 2026
f278278
fix(envoy): reduce connect_timeout and add active health checks
aepfli Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,14 @@ services:
- name: local-sync-service
type: LOGICAL_DNS
dns_lookup_family: V4_ONLY
connect_timeout: 0.25s
http2_protocol_options: {}
health_checks:
- timeout: 1s
interval: 1s
unhealthy_threshold: 1
healthy_threshold: 1
tcp_health_check: {}
load_assignment:
cluster_name: local-sync-service
endpoints:
Expand All @@ -148,7 +155,14 @@ services:
- name: local-rpc-service
type: LOGICAL_DNS
dns_lookup_family: V4_ONLY
connect_timeout: 0.25s
http2_protocol_options: {}
health_checks:
- timeout: 1s
interval: 1s
unhealthy_threshold: 1
healthy_threshold: 1
tcp_health_check: {}
load_assignment:
cluster_name: local-rpc-service
endpoints:
Expand Down
8 changes: 5 additions & 3 deletions gherkin/config.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ Feature: Configuration Test
| option | type | value |
| providerId | String | providerId |

@env-var
Scenario Outline: Dedicated Config via Env_var
Given an environment variable "<env>" with value "<value>"
When a config was initialized
Expand Down Expand Up @@ -274,7 +275,7 @@ Feature: Configuration Test
| option | env | type | value |
| providerId | FLAGD_PROVIDER_ID | String | env-providerId |

@in-process @sync-port
@in-process @sync-port @env-var
Scenario Outline: Dedicated Config via Env_var special In-process case
Given an environment variable "<env>" with value "<value>"
And an option "resolver" of type "ResolverType" with value "in-process"
Expand All @@ -284,7 +285,7 @@ Feature: Configuration Test
| option | env | type | value |
| port | FLAGD_SYNC_PORT | Integer | 1234 |

@file
@file @env-var
Scenario Outline: Dedicated Config via Env_var special file case
Given an environment variable "<env>" with value "<value>"
And an option "offlineFlagSourcePath" of type "String" with value "some-path"
Expand All @@ -296,6 +297,7 @@ Feature: Configuration Test
| resolver | FLAGD_RESOLVER | ResolverType | file |
| resolver | FLAGD_RESOLVER | ResolverType | FILE |

@env-var
Scenario Outline: Dedicated Config via Env_var and set
Given an environment variable "<env>" with value "<env-value>"
And an option "<option>" of type "<type>" with value "<value>"
Expand Down Expand Up @@ -376,7 +378,7 @@ Feature: Configuration Test
| option | env | type | value | env-value |
| providerId | FLAGD_PROVIDER_ID | String | providerId | env-prov |

@in-process @sync-port
@in-process @sync-port @env-var
Scenario: FLAGD_SYNC_PORT takes priority over FLAGD_PORT
Given an environment variable "FLAGD_SYNC_PORT" with value "9999"
And an environment variable "FLAGD_PORT" with value "8888"
Expand Down
Loading