Skip to content

feat(fractional): add nested fractional expression gherkin scenarios #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddbaert merged 2 commits into from
Mar 18, 2026
Merged

feat(fractional): add nested fractional expression gherkin scenarios #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecbfeed
test(fractional): add nested fractional gherkin scenarios
aepfli Mar 16, 2026
fdcf310
test(fractional): add invalid/missing variant fallback cases
aepfli Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions flags/custom-ops.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,48 @@
]
}
},
"fractional-nested-if-flag": {
"state": "ENABLED",
"variants": {
"premium": "premium",
"standard": "standard",
"fallback": "fallback"
},
"defaultVariant": "fallback",
"targeting": {
"fractional": [
{ "var": "targetingKey" },
[
{
"if": [
{ "==": [{ "var": "tier" }, "premium"] },
"premium",
"standard"
]
},
50
],
[ "standard", 50 ]
]
}
},
"fractional-nested-var-flag": {
"state": "ENABLED",
"variants": {
"red": "red",
"green": "green",
"blue": "blue",
"fallback": "fallback"
},
"defaultVariant": "fallback",
"targeting": {
"fractional": [
{ "var": "targetingKey" },
[ { "var": "color" }, 50 ],
[ "blue", 50 ]
]
}
},
"starts-ends-flag": {
"state": "ENABLED",
"variants": {
Expand Down
36 changes: 36 additions & 0 deletions gherkin/targeting.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,42 @@ Feature: Targeting rules
| 6LvT0 | upper |
| ceQdGm | upper |

# Nested JSON Logic expressions as bucket variant names.
# Requires providers to support the @fractional-nested feature.
# Use -t "not @fractional-nested" to exclude during transition.
@fractional @fractional-nested
Scenario Outline: Fractional operator with nested if expression as variant name
# fractional-nested-if-flag: seed=targetingKey, bucket0=[if(tier=="premium","premium","standard"),50], bucket1=["standard",50]
# jon@company.com bv(100)=36 → bucket0; user1 bv(100)=76 → bucket1
Given a String-flag with key "fractional-nested-if-flag" and a default value "fallback"
And a context containing a targeting key with value "<targetingKey>"
And a context containing a key "tier", with type "String" and with value "<tier>"
When the flag was evaluated with details
Then the resolved details value should be "<value>"
Examples:
| targetingKey | tier | value |
| jon@company.com | premium | premium |
| jon@company.com | basic | standard |
| user1 | premium | standard |
| user1 | basic | standard |

@fractional @fractional-nested
Scenario Outline: Fractional operator with nested var expression as variant name
# fractional-nested-var-flag: seed=targetingKey, bucket0=[var("color"),50], bucket1=["blue",50]
# jon@company.com bv(100)=36 → bucket0 (resolves var "color"); user1 bv(100)=76 → bucket1 ("blue")
Given a String-flag with key "fractional-nested-var-flag" and a default value "fallback"
And a context containing a targeting key with value "<targetingKey>"
And a context containing a key "color", with type "String" and with value "<color>"
When the flag was evaluated with details
Then the resolved details value should be "<value>"
Examples:
| targetingKey | color | value |
| jon@company.com | red | red |
| jon@company.com | green | green |
| user1 | red | blue |
| jon@company.com | yellow | fallback |
| jon@company.com | | fallback |

@string
Scenario Outline: Substring operators
Given a String-flag with key "starts-ends-flag" and a default value "fallback"
Expand Down
Loading