Skip to content

feat(evaluators): add nested $ref resolution scenarios #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aepfli wants to merge 3 commits into
base: main
Choose a base branch
from
+78 −2
Open

feat(evaluators): add nested $ref resolution scenarios #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e975b22
test(evaluators): add edge case scenarios for nested $ref resolution
aepfli Mar 12, 2026
eee9ff5
test(evaluator-refs): mirror nested ref edge case scenarios to evalua…
aepfli Mar 30, 2026
963cb3b
fix(evaluator-refs): inline is_ballmer logic in is_privileged, remove…
aepfli Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions evaluator/flags/testkit-flags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,18 @@
["two", 50]
]
}
},
"nested-ref-targeted-flag": {
"state": "ENABLED",
"variants": {
"privileged": "privileged",
"standard": "standard",
"none": "none"
},
"defaultVariant": "none",
"targeting": {
"if": [{"$ref": "is_privileged"}, "privileged", "standard"]
}
}
},
"$evaluators": {
Expand All @@ -482,6 +494,12 @@
"ballmer@macrosoft.com",
{"var": ["email"]}
]
},
"is_privileged": {
"or": [
{"==": ["ballmer@macrosoft.com", {"var": ["email"]}]},
{"==": ["admin", {"var": ["role"]}]}
]
}
}
}
13 changes: 13 additions & 0 deletions evaluator/gherkin/evaluator-refs.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,16 @@ Feature: Evaluator evaluator refs
| key | value |
| some-email-targeted-flag | hi |
| some-other-email-targeted-flag | yes |

@evaluator-ref-edge-cases
Scenario Outline: Nested evaluator ref resolution
Given an evaluator
And a String-flag with key "nested-ref-targeted-flag" and a fallback value "fallback"
And a context containing a key "<context_key>", with type "String" and with value "<context_value>"
When the flag was evaluated with details
Then the resolved details value should be "<value>"
Examples:
| context_key | context_value | value |
| email | ballmer@macrosoft.com | privileged |
| role | admin | privileged |
| email | other@example.com | standard |
36 changes: 34 additions & 2 deletions flags/evaluator-refs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,47 @@
"no"
]
}
},
"nested-ref-targeted-flag": {
"state": "ENABLED",
"variants": {
"privileged": "privileged",
"standard": "standard",
"none": "none"
},
"defaultVariant": "none",
"targeting": {
"if": [
{
"$ref": "is_privileged"
},
"privileged",
"standard"
]
}
}
},
"$evaluators": {
"is_ballmer": {
"==": [
"ballmer@macrosoft.com",
{
"var": [
"email"
"var": ["email"]
}
]
},
"is_privileged": {
"or": [
{
"==": [
"ballmer@macrosoft.com",
{"var": ["email"]}
]
},
{
"==": [
"admin",
{"var": ["role"]}
]
}
]
Expand Down
13 changes: 13 additions & 0 deletions gherkin/targeting.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Feature: Targeting rules
And a stable flagd provider

# evaluator refs
@evaluator-refs
Scenario Outline: Evaluator reuse
Given a String-flag with key "<key>" and a default value "fallback"
And a context containing a key "email", with type "String" and with value "ballmer@macrosoft.com"
Expand All @@ -20,6 +21,18 @@ Feature: Targeting rules
| some-email-targeted-flag | hi |
| some-other-email-targeted-flag | yes |

@evaluator-refs @evaluator-ref-edge-cases
Scenario Outline: Nested evaluator ref resolution
Given a String-flag with key "nested-ref-targeted-flag" and a default value "fallback"
And a context containing a key "<context_key>", with type "String" and with value "<context_value>"
When the flag was evaluated with details
Then the resolved details value should be "<value>"
Examples:
| context_key | context_value | value |
| email | ballmer@macrosoft.com | privileged |
| role | admin | privileged |
| email | other@example.com | standard |

# custom operators
# @fractional-v1: legacy float-based bucketing (abs(hash) / i32::MAX * 100)
# @fractional-v2: high-precision integer bucketing ((hash * totalWeight) >> 32)
Expand Down
Loading