fix: do not perform flag resolution if not ready#16
Merged
Conversation
The flag resolution was being performed regardles of the state of the client provider. Now, if the provider state is :not_ready or :fatal, it will not attempt to resolve the flag value. Signed-off-by: Eduardo Cunha <eduardo.cunha@ist.utl.pt>
ejscunha
force-pushed
the
fix/do-not-perform-flag-resolution-if-not-ready
branch
from
ae59506 to
c36a6e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
The flag resolution was being performed regardless of the state of the client provider.
Now, if the provider state is
:not_readyor:fatal, it will not attempt to resolve the flag value.