Add display configuration options to gvawatermark element #497
+137
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbujewsk
requested review from
BaoHuiling,
OskarFiedot,
ZiningLi,
dmichalo,
jmotow,
marcin-wadolkowski,
mholowni,
msmiatac,
nszczygl9,
oonyshch,
pbartosik,
qianlongding,
walidbarakat,
yangjianfeng1208 and
yunowo
as code owners
yunowo
reviewed
Jan 4, 2026
| "disp-avgfps", "Display Average FPS", | ||
| "If true, display the average FPS read from gvafpscounter element on the output video, (default false)\n" | ||
| "\t\t\tThe gvafpscounter element must be present in the pipeline.\n" | ||
| "\t\t\te.g.: ... ! gwatermark ! gvafpscounter ! ...", |
yunowo
reviewed
Jan 4, 2026
| async-handling : The bin will handle Asynchronous state changes | ||
| flags: readable, writable | ||
| Boolean. Default: false | ||
| cfg : Comma separated list of KEY=VALUE parameters specific to. Please see user guide for more details. |
Member
There was a problem hiding this comment.
Where is the detailed user guide?
yunowo
reviewed
Jan 4, 2026
| e.g.: cfg=show-labels=off | ||
| e.g.: cfg=text-scale=0.5 | ||
| flags: readable, writable | ||
| String. Default: "show-labels=true,text-scale=1.0" |
Member
There was a problem hiding this comment.
For default value I think null is enough because there is already default values for each setting
yunowo
reviewed
Jan 4, 2026
| g_param_spec_string("device", "Target device", "CPU or GPU. Default is CPU.", | ||
| DEFAULT_DEVICE, kDefaultGParamFlags)); | ||
|
|
||
| g_object_class_install_property(gobject_class, PROP_OBB, |
yunowo
reviewed
Jan 4, 2026
Comment on lines
169
to
+170
| bool _disp_avgfps = false; | ||
| }; | ||
| gchar *_displ_cfg = nullptr; |
Member
There was a problem hiding this comment.
The mix use of disp and displ should be avoided
yunowo
reviewed
Jan 4, 2026
| struct DisplCfg { | ||
| bool show_labels = true; | ||
| double text_scale = 1.0; | ||
| } _displCfg; |
Member
There was a problem hiding this comment.
Mix use of camel case _displCfg and snake case _displ_cfg should be avoided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.