fix: don't parse the header as a symbol#40
Open
DexrnZacAttack wants to merge 1 commit intoopen-ead:masterfrom
Open
fix: don't parse the header as a symbol#40DexrnZacAttack wants to merge 1 commit intoopen-ead:masterfrom
DexrnZacAttack wants to merge 1 commit intoopen-ead:masterfrom
Conversation
Without this patch, attempting to run `check` throws:
```
Error: failed to construct FunctionChecker
Caused by:
invalid digit found in string
```
A quick check by printing inside parse_address shows that it's attempting to parse "Address" as an address, meaning it's attempting to parse the CSV header as a symbol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, attempting to run
checkthrows:A quick check by printing inside parse_address shows that it's attempting to parse "Address" as an address, meaning it's attempting to parse the CSV header as a symbol.
This change is