util: Fix iterators of BitArray and IntrusiveList#60
Open
MonsterDruide1 wants to merge 2 commits intoopen-ead:masterfrom
Open
util: Fix iterators of BitArray and IntrusiveList#60MonsterDruide1 wants to merge 2 commits intoopen-ead:masterfrom
BitArray and IntrusiveList#60MonsterDruide1 wants to merge 2 commits intoopen-ead:masterfrom
Conversation
MonsterDruide1
changed the title
BitArray::reverse_iteratorsBitArray and IntrusiveList
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a line like this causes cryptic error messages:
nn::util::BitArray::const_reverse_iterator it = arr.rbegin();After two hours of debugging and working with C++ iterators, I found a fix: Declaring more of the elements required to build
iterator_trait, and changing them topublicto allow accessing them outside.This change is