Skip to content

message: Add ScalableFontMgr headers#3

Open
german77 wants to merge 2 commits intoopen-ead:mainfrom
german77:font
Open

message: Add ScalableFontMgr headers#3
german77 wants to merge 2 commits intoopen-ead:mainfrom
german77:font

Conversation

@german77
Copy link

@german77 german77 commented Feb 5, 2026

MapLayout registers a few fonts. These headers need to be added.

I updated the clang format file because it wasn't working properly.


This change is Reviewable

Copy link

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 5 files and all commit messages, and made 8 comments.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on german77).


CMakeLists.txt line 6 at r1 (raw file):

	include/euiControlBase.h
	include/message/euiScalableFontMgr.h
	include/message/euiFontMgr.h

Suggestion:

	include/message/euiFontMgr.h
	include/message/euiScalableFontMgr.h

CMakeLists.txt line 9 at r1 (raw file):

	include/sys/euiSharcArchive.h

	src/euiControlBase.cpp

use four spaces instead of tabs

Code quote:

	include/euiControlBase.h
	include/message/euiScalableFontMgr.h
	include/message/euiFontMgr.h
	include/sys/euiSharcArchive.h

	src/euiControlBase.cpp

include/message/euiFontMgr.h line 26 at r1 (raw file):

    FontMgr();

    void initialize(sead::Heap*, void*, u32, const sead::Buffer<const char*>&,

Suggestion:

    FontMgr();
    virtual ~FontMgr();

    void initialize(sead::Heap*, void*, u32, const sead::Buffer<const char*>&,

include/message/euiFontMgr.h line 39 at r1 (raw file):

    void setRubyFont(const nn::font::Font*);
    bool isScalableFont(const sead::SafeString&) const;
    void findFontName(sead::BufferedSafeString*, const nn::font::Font*) const;

Suggestion:

bool findFontName(sead::BufferedSafeString*, const nn::font::Font*) const;

include/message/euiFontMgr.h line 45 at r1 (raw file):

private:
    char filler[0x8];
    SharcArchive mSharcArchive;

That's the vtable

Suggestion:

private:
    SharcArchive mSharcArchive;

include/message/euiScalableFontMgr.h line 27 at r1 (raw file):

    ScalableFontMgr();

    void initialize(const InitializeArg&);

Suggestion:

    ScalableFontMgr();
    virtual ~ScalableFontMgr();

    void initialize(const InitializeArg&);

include/sys/euiSharcArchive.h line 17 at r1 (raw file):

    SharcArchive();

    void finalize();

Suggestion:

    SharcArchive();
    ~SharcArchive();

    void finalize();

include/sys/euiSharcArchive.h line 22 at r1 (raw file):

private:
    char _filler[0x8];

Suggestion:

sead::Resource* mResource;

Copy link
Author

@german77 german77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@german77 made 8 comments.
Reviewable status: 1 of 5 files reviewed, 8 unresolved discussions (waiting on MonsterDruide1).


CMakeLists.txt line 9 at r1 (raw file):

Previously, MonsterDruide1 wrote…

use four spaces instead of tabs

Done.


include/message/euiFontMgr.h line 45 at r1 (raw file):

Previously, MonsterDruide1 wrote…

That's the vtable

Done.


CMakeLists.txt line 6 at r1 (raw file):

	include/euiControlBase.h
	include/message/euiScalableFontMgr.h
	include/message/euiFontMgr.h

Done.


include/message/euiFontMgr.h line 26 at r1 (raw file):

    FontMgr();

    void initialize(sead::Heap*, void*, u32, const sead::Buffer<const char*>&,

Done.


include/message/euiFontMgr.h line 39 at r1 (raw file):

    void setRubyFont(const nn::font::Font*);
    bool isScalableFont(const sead::SafeString&) const;
    void findFontName(sead::BufferedSafeString*, const nn::font::Font*) const;

Done.


include/message/euiScalableFontMgr.h line 27 at r1 (raw file):

    ScalableFontMgr();

    void initialize(const InitializeArg&);

Done.


include/sys/euiSharcArchive.h line 17 at r1 (raw file):

    SharcArchive();

    void finalize();

Done.


include/sys/euiSharcArchive.h line 22 at r1 (raw file):

private:
    char _filler[0x8];

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants