-
Notifications
You must be signed in to change notification settings - Fork 1
added information about nullable fields in response #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Ravinskij-Vladimir
wants to merge
1
commit into
main
Choose a base branch
from
swagger-nullable-info
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
domain/src/main/java/com/opencu/bookit/domain/model/statistics/FullStats.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| package com.opencu.bookit.domain.model.statistics; | ||
|
|
||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
| import java.util.List; | ||
|
|
||
| public record FullStats( | ||
| List<BookingStats> stats, | ||
| @Schema(nullable = true) | ||
| StatsSummary summary | ||
| ) {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| package com.opencu.bookit.adapter.out.security.spring.payload.response; | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
| import lombok.Data; | ||
|
|
||
| import java.util.UUID; | ||
|
|
@@ -10,6 +11,7 @@ public class JwtResponse { | |
| private final String type = "Bearer"; | ||
| private final UUID id; | ||
| private final String username; | ||
| @Schema(nullable = true, description = "Email may be null") | ||
| private final String email; | ||
| private final String firstName; | ||
| private final String lastName; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lastName не обязательно передаётся нам из тг |
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
|
|
||
| import com.opencu.bookit.domain.model.user.Role; | ||
| import com.opencu.bookit.domain.model.user.UserStatus; | ||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
|
|
||
| import java.time.LocalDateTime; | ||
| import java.util.Set; | ||
|
|
@@ -12,12 +13,17 @@ public record MeResponse( | |
| Long tgId, | ||
| String firstName, | ||
| String lastName, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lastName не обязателен |
||
| @Schema(nullable = true) | ||
| String photoUrl, | ||
| @Schema(nullable = true) | ||
| String email, | ||
| @Schema(nullable = true) | ||
| String phone, | ||
| UserStatus status, | ||
| LocalDateTime createdAt, | ||
| @Schema(nullable = true) | ||
| LocalDateTime updatedAt, | ||
| @Schema(nullable = true) | ||
| String username, | ||
| Set<Role> roles | ||
| ) {} | ||
1 change: 1 addition & 0 deletions
1
web-adapter/src/main/java/com/opencu/bookit/adapter/in/web/dto/response/TicketResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
username берется из тг, где он не обязателен