feat: remove PDF download button and option #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most browser PDF viewers will display an option for downloading the PDF. Because of this, the separate PDF download button is redundant. Also the option to uncheck "PDF Download Allowed" is misleading, because removing the button can't disallow downloading. Private-ref: https://tasks.opencraft.com/browse/BB-9935
Member
Author
|
Closing because we're not going this direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most browser PDF viewers will display an option for downloading the PDF. Because of this, the separate PDF download button is redundant. Also the option to uncheck "PDF Download Allowed" is misleading, because removing the button can't disallow downloading.
Supporting information
Private-ref: https://tasks.opencraft.com/browse/BB-9935
Testing instructions
Other information
This depends on open-craft/xblock-pdf#5, as the branch from that PR is what is deployed and what we're testing with. If this goes ahead, the plan would be to create a new client branch based on that PR, and merge this PR into the new client branch.