Skip to content

refactor: standardize delete confirmation pattern #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rianjs merged 1 commit into from
Jan 29, 2026
Merged

refactor: standardize delete confirmation pattern #35

rianjs merged 1 commit into from
Jan 29, 2026

Conversation

@rianjs
Copy link
Contributor

@rianjs rianjs commented Jan 29, 2026

Summary

  • Create shared prompt package with Confirm() and ConfirmOrForce() functions
  • Update cfl page delete to use prompt.Confirm()
  • Update jtk issues delete to use interactive confirmation (was --force only)
  • Both tools now have consistent UX: interactive confirmation by default, --force to skip

Before (jtk)

$ jtk issues delete PROJ-123
⚠  This will permanently delete issue PROJ-123. This action cannot be undone.
ℹ  Use --force to skip this confirmation.
error: deletion cancelled (use --force to confirm)

After (jtk)

$ jtk issues delete PROJ-123
This will permanently delete issue PROJ-123. This action cannot be undone.
Are you sure? [y/N]: y
✓ Deleted issue PROJ-123

Test plan

  • Run make test - all tests pass
  • New prompt package has comprehensive tests

Fixes #25

🤖 Generated with Claude Code

@rianjs @claude
refactor: standardize delete confirmation pattern
566172c 
Create shared prompt package with Confirm() function for interactive
user confirmation. Update both cfl and jtk delete commands to use
consistent interactive confirmation.

Changes:
- Add shared/prompt package with Confirm() and ConfirmOrForce() functions
- Update cfl page delete to use prompt.Confirm()
- Update jtk issues delete to use interactive confirmation (was --force only)
- Both tools now support interactive confirmation with --force to skip

The jtk delete command now matches cfl's UX: prompts for confirmation
by default, --force to skip prompt.

Fixes #25

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@rianjs rianjs merged commit a54a048 into main Jan 29, 2026
7 checks passed
@rianjs rianjs deleted the refactor/25-standardize-delete-confirmation branch January 29, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor: standardize delete confirmation pattern

2 participants

@rianjs