refactor: remove error re-exports in jtk #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary error variable re-exports and helper functions from jtk's API package. Callers now use the shared errors package directly. - Remove ErrNotFound, ErrUnauthorized, ErrForbidden, ErrBadRequest, ErrRateLimited, ErrServerError re-exports - Remove IsNotFound, IsUnauthorized, IsForbidden wrapper functions - Keep tool-specific errors: ErrIssueKeyRequired, ErrProjectKeyRequired - Update tests to use sharederrors directly Fixes #22 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ErrNotFound,ErrUnauthorized, etc.) from jtk's API packageIsNotFound,IsUnauthorized,IsForbidden)ErrIssueKeyRequired,ErrProjectKeyRequiredsharederrorsdirectlyCallers can now import the shared errors package directly for clearer dependency chains.
Test plan
make test- all tests passFixes #22
🤖 Generated with Claude Code