Skip to content

Conversation

@rianjs
Copy link
Contributor

@rianjs rianjs commented Jan 29, 2026

Summary

  • Replace 5-file subcommand pattern with single-file argument-based pattern
  • Usage changes from cfl completion bash (subcommand) to cfl completion bash (argument)
  • Delete bash.go, zsh.go, fish.go, powershell.go
  • Matches jtk's simpler completion implementation

Test plan

  • All shell completions generate correctly (bash, zsh, fish, powershell)
  • Invalid shell arguments are rejected
  • Missing shell argument shows error

Closes #19

🤖 Generated with Claude Code

- Replace 5-file subcommand pattern with single-file argument-based pattern
- Usage changes from `cfl completion bash` (subcommand) to `cfl completion bash` (argument)
- Delete bash.go, zsh.go, fish.go, powershell.go
- Matches jtk's simpler completion implementation

Closes #19

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@rianjs rianjs merged commit 218fdb8 into main Jan 29, 2026
7 checks passed
@rianjs rianjs deleted the refactor/19-consolidate-completion branch January 29, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: consolidate completion commands

2 participants