Skip to content

update badges hook: rename to include open-atmos; fix version control#63

Open
AgnieszkaZaba wants to merge 14 commits intoopen-atmos:mainfrom
AgnieszkaZaba:badges-hook
Open

update badges hook: rename to include open-atmos; fix version control#63
AgnieszkaZaba wants to merge 14 commits intoopen-atmos:mainfrom
AgnieszkaZaba:badges-hook

Conversation

@AgnieszkaZaba
Copy link
Collaborator

No description provided.

# Conflicts:
#	hooks/check_notebook_open_atmos_structure.py
#	hooks/check_notebooks.py
#	pyproject.toml
#	tests/examples/good.ipynb
@slayoo
Copy link
Member

slayoo commented Feb 7, 2026

we have one pylint complaint:

************* Module test_check_badges_examples
tests/test_check_badges_examples.py:14:0: E0611: No name 'check_badges' in module 'hooks' (no-name-in-module)

-----------------------------------
Your code has been rated at 9.89/10

@AgnieszkaZaba
Copy link
Collaborator Author

we have one pylint complaint:

************* Module test_check_badges_examples
tests/test_check_badges_examples.py:14:0: E0611: No name 'check_badges' in module 'hooks' (no-name-in-module)

-----------------------------------
Your code has been rated at 9.89/10

Thanks!
It took me a while to understand and fix (hook was renamed).
This PR still needs work, especially cleanup after merge.

@AgnieszkaZaba AgnieszkaZaba self-assigned this Feb 8, 2026
@AgnieszkaZaba
Copy link
Collaborator Author

AgnieszkaZaba commented Feb 15, 2026

Repos using changes in this PR (as test cases for hook):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants