new logic for tests - bad and good example; hook checking nb outputs;#61
Merged
AgnieszkaZaba merged 34 commits intoopen-atmos:mainfrom Feb 7, 2026
Merged
new logic for tests - bad and good example; hook checking nb outputs;#61AgnieszkaZaba merged 34 commits intoopen-atmos:mainfrom
AgnieszkaZaba merged 34 commits intoopen-atmos:mainfrom
Conversation
13 tasks
Sfonxu
approved these changes
Dec 24, 2025
Member
Contributor
I think it could, with maybe a more clear naming convention (like tests/passing/(hook_name).py, tests/failing/(hook_name).py )? Same goes for example notebooks I suppose. And maybe a good idea would be to add a CI job to run the hooks on those files as well. |
AgnieszkaZaba
commented
Jan 10, 2026
Collaborator
Author
|
slayoo
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.