Skip to content

Layer thickness function#38

Merged
jtgasparik merged 27 commits intoopen-atmos:mainfrom
jtgasparik:layer_thickness_function
Jan 7, 2026
Merged

Layer thickness function#38
jtgasparik merged 27 commits intoopen-atmos:mainfrom
jtgasparik:layer_thickness_function

Conversation

@jtgasparik
Copy link
Collaborator

@jtgasparik jtgasparik commented Nov 19, 2025

This PR encompasses 3 function changes summarized below.

  1. A function was added to compute the thickness of a single layer in the single particle aerosol representation. Function accepts an aero_phase_idx and returns the thickness that the aerosol phase resides in.
  2. A second function (called aero_rep_get_effective_layer_radius__m) was added that computes the radius of a specified layer in an aerosol particle in the single particle representation. This uses the same logic as the function that computes the radius of a particle (aero_rep_get_effective_radius__m in previous versions of this model). However, the code is modified to only computes the radius up to a specified layer. The modal/binned representation returns the radius of the entire particle (since layers do not exist in this representation).
  3. Modifications to the function that calculates the radius of a particle. In the single particle representation, this function now calls the aero_rep_get_effective_layer_radius__m function and calculates the radius of the outermost layer. In the modal/binned representation this function returns the radius and remains the same as in previous versions.

Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one naming change suggestion, but everything else looks good.

jtgasparik and others added 11 commits January 5, 2026 22:04
Co-authored-by: Matt Dawson <mattldawson@gmail.com>
Co-authored-by: Matt Dawson <mattldawson@gmail.com>
Co-authored-by: Matt Dawson <mattldawson@gmail.com>
Co-authored-by: Matt Dawson <mattldawson@gmail.com>
Co-authored-by: Matt Dawson <mattldawson@gmail.com>
Co-authored-by: Matt Dawson <mattldawson@gmail.com>
Co-authored-by: Matt Dawson <mattldawson@gmail.com>
Co-authored-by: Matt Dawson <mattldawson@gmail.com>
Co-authored-by: Matt Dawson <mattldawson@gmail.com>
Co-authored-by: Matt Dawson <mattldawson@gmail.com>
@jtgasparik jtgasparik requested a review from mattldawson January 6, 2026 20:04
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@jtgasparik jtgasparik merged commit 1819930 into open-atmos:main Jan 7, 2026
3 checks passed
@jtgasparik jtgasparik deleted the layer_thickness_function branch January 7, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants